Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[urlscan-enrichment] Make indicator creation optional #3139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[urlscan-enrichment] Make indicator creation optional #3139

wants to merge 1 commit into from
+31 −15

Conversation

DucNg
Copy link
Contributor

@DucNg DucNg commented Dec 13, 2024 •
edited
Loading

Proposed changes

  • Make indicator creation optional
  • Add a URLSCAN_ENRICHMENT_CREATE_INDICATOR variable to decide whether or not to create indicator when enrichment is done

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@DucNg DucNg force-pushed the urlscan-optional-indicator branch from 106a1e4 to daaf14c Compare December 13, 2024 15:10
@romain-filigran romain-filigran added the community use to identify PR from community label Dec 27, 2024
@romain-filigran romain-filigran added this to the PRs backlog milestone Jan 7, 2025
@DucNg
Copy link
Contributor Author

DucNg commented Jan 9, 2025

Gentle ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community use to identify PR from community
Projects
None yet
Milestone
PRs backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@DucNg @romain-filigran